Skip to content

Updated CODEOWNER file#678

Merged
kyasbal merged 1 commit into
GoogleCloudPlatform:mainfrom
kyasbal:push-xymxvwuurqom
May 22, 2026
Merged

Updated CODEOWNER file#678
kyasbal merged 1 commit into
GoogleCloudPlatform:mainfrom
kyasbal:push-xymxvwuurqom

Conversation

@kyasbal

@kyasbal kyasbal commented May 21, 2026

Copy link
Copy Markdown
Member

Current CODEOWNER is not meaningfully used in this project. We asks someone else to review once a PR is ready and we are unable to review very carefully enough to catch complex or small issues that requires language or domain specific deep knowledge. This PR updates CODEOWNER simply regardless of their proficiency.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the .github/CODEOWNERS file by replacing directory-specific ownership with a single wildcard rule for all files. The review feedback highlights that the removal of @yfuruyama appears inconsistent with the intended goals and points out a missing trailing newline, providing a code suggestion to resolve these issues.

Comment thread .github/CODEOWNERS
@kyasbal kyasbal marked this pull request as ready for review May 21, 2026 05:10
@kyasbal kyasbal enabled auto-merge May 21, 2026 05:11
@kyasbal kyasbal added this pull request to the merge queue May 22, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 97b374f May 22, 2026
13 of 14 checks passed
@kyasbal kyasbal deleted the push-xymxvwuurqom branch May 22, 2026 04:35
kyasbal added a commit that referenced this pull request May 25, 2026
* Removing unused CORS code (#619)

* Removing unused CORS code

* Update pkg/core/init/default/defaultextension.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: kyasbal <kyasbal1994@gmail.com>

---------

Signed-off-by: kyasbal <kyasbal1994@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Replaced unsafe innerHTML with textContent (#620)

* feat(startup): implement smart component and integrate data loading (#599)

* feat(startup): add inspection list components

* feat(startup): implement smart component and integrate data loading #558

* Fix name of the function pointed out by the review

* chore: fix make setup error in jj and update dev guide (#629)

* chore: fix make setup error in jj and update dev guide

* fix commented issues on review

* fixed minor issues on Makefile (#644)

* Merge epic/csm-parser into main (#645)

* Add Inventory/Discovery tasks for parsing the map from NEG name to BS name (#635)

* Add fleet PJ form task and query task to gather CSM TD audit logs (#636)

* Add Inventory/Discovery tasks for parsing the map from NEG name to BS name

* Adding form task to receive the fleet project and query task to gather logs from Cloud Logging

* Add timeline mapper for TD resource logs (#637)

* Add Inventory/Discovery tasks for parsing the map from NEG name to BS name

* Adding form task to receive the fleet project and query task to gather logs from Cloud Logging

* Add timeline mapper for traffic director resource logs

* 🐛 fix set-input suggestion being wrapped for every lines (#638)

* fix set-input suggestion being wrapped for every lines

* Update web/src/app/timeline-toolbar/components/set-input-popup.component.scss

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: kyasbal <kyasbal1994@gmail.com>

---------

Signed-off-by: kyasbal <kyasbal1994@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Fix bugs to register the CSM TD parser tasks (#647)

* Fix the same issue of #638 (#659)

* Adding make clean command (#651)

* Addming make clean command

* fixed commented points

* Removing unused old headers on frontend (#660)

* removed prefix 'v2' in shader files (#661)

* rename commonlogk8sauditv2 to commonlogk8saudit (#662)

* fixed the flaky backend test due to race condition (#665)

* improved sticky header to show resource layer (#663)

* Removed redundant v from the version string (#671)

* bugfix: automatic log scroll is not matching to the actual element (#675)

* bugfix: ignore changing selected timeline when user clicked a log from log list (#674)

* bugfix: automatic scroll to the beginning time of log query when user selected a timeline without point to a log (#676)

* bugfix: scaling around right edge of query duration may be clipped to jump to other timing (#677)

* Updated CODEOWNER file (#678)

* Updated the release.yml for GitHub (#679)

---------

Signed-off-by: kyasbal <kyasbal1994@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants